feat(stackable-telemetry): Add RollingFileAppender #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Techassi
requested changes
Jan 13, 2025
|
Thanks for all the feedback! Adjusted everything in bfe89a7 |
Techassi
changed the title
Techassi
reviewed
Jan 16, 2025
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
Techassi
reviewed
Jan 17, 2025
Comment on lines
+482
to
+491
| pub fn with_file_output( | ||
| self, | ||
| file_log_settings: FileLogSettings, | ||
| ) -> TracingBuilder<builder_state::Config> { | ||
| TracingBuilder { | ||
| service_name: self.service_name, | ||
| console_log_settings: self.console_log_settings, | ||
| file_log_settings, | ||
| otlp_log_settings: self.otlp_log_settings, | ||
| otlp_trace_settings: self.otlp_trace_settings, |
There was a problem hiding this comment.
note: #940 changed the API interface of these functions and as such I suggest to also change it here to be in line.
Suggested change
| pub fn with_file_output( | |
| self, | |
| file_log_settings: FileLogSettings, | |
| ) -> TracingBuilder<builder_state::Config> { | |
| TracingBuilder { | |
| service_name: self.service_name, | |
| console_log_settings: self.console_log_settings, | |
| file_log_settings, | |
| otlp_log_settings: self.otlp_log_settings, | |
| otlp_trace_settings: self.otlp_trace_settings, | |
| pub fn with_file_output( | |
| self, | |
| file_log_settings: impl Into<FileLogSettings>, | |
| ) -> TracingBuilder<builder_state::Config> { | |
| TracingBuilder { | |
| service_name: self.service_name, | |
| console_log_settings: self.console_log_settings, | |
| file_log_settings: file_log_settings.into(), | |
| otlp_log_settings: self.otlp_log_settings, | |
| otlp_trace_settings: self.otlp_trace_settings, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#639. Adds the RollingFileAppender to the stackable-telemetry crate.
Add RollingFileAppender to stackable-telemetry (as was done in #814).
Definition of Done Checklist
Author
Reviewer
Acceptance